Editors: reactions on review comments, and who can be @-mentioned, in --review #79

Closed
opened 2026-11-13 00:45:40 +01:00 by thatrichan · 0 comments
Owner

The JetBrains companion's review cards (jetbrains 1.2.0) can show emoji reactions on comments and complete @-mentions, as Revue's own conversation does, but the command line doesn't say either yet, and companions only talk to Revue through it. Follows #78 (viewed marks, editor 7).

What the companion needs

  1. Reactions on each thread comment in --review: "reactions": [{"content": "+1"|"-1"|"laugh"|"hooray"|"confused"|"heart"|"rocket"|"eyes", "count": N, "mine": true|false}], [] when there are none (missing means Revue can't tell, e.g. a service without reactions).
  2. revue --react <url> --comment <id> --reaction <content> [--off]: adds your reaction (or, with --off, takes it back) as Revue's own conversation does, answering {"reacted": true|false}; exit codes and --headless as the other review questions.
  3. Who can be mentioned: "mentionable": [{"login": "…", "name": "…", "avatar": "https://…"}] at the top of --review's answer: the pull request's people first (author, reviewers, commenters, assignees), then the others who can review in the repository, as Revue's own @ list orders them.
  4. editor 8 once these are in, and docs/command-line.md updated.

What the companion does with it

Already built, shown only once a Revue's answer carries the fields:

  • A reactions row under each comment (the counts, yours highlighted, a picker to add one).
  • @-completion from mentionable (today it falls back to the people in the review's conversations).

On Bitbucket and Forgejo, where reactions differ or don't exist, leaving reactions out is fine: the companion then shows none.

The JetBrains companion's review cards (jetbrains 1.2.0) can show emoji reactions on comments and complete @-mentions, as Revue's own conversation does, but the command line doesn't say either yet, and companions only talk to Revue through it. Follows #78 (viewed marks, `editor 7`). ## What the companion needs 1. **Reactions** on each thread comment in `--review`: `"reactions": [{"content": "+1"|"-1"|"laugh"|"hooray"|"confused"|"heart"|"rocket"|"eyes", "count": N, "mine": true|false}]`, `[]` when there are none (missing means Revue can't tell, e.g. a service without reactions). 2. **`revue --react <url> --comment <id> --reaction <content> [--off]`**: adds your reaction (or, with `--off`, takes it back) as Revue's own conversation does, answering `{"reacted": true|false}`; exit codes and `--headless` as the other review questions. 3. **Who can be mentioned**: `"mentionable": [{"login": "…", "name": "…", "avatar": "https://…"}]` at the top of `--review`'s answer: the pull request's people first (author, reviewers, commenters, assignees), then the others who can review in the repository, as Revue's own @ list orders them. 4. **`editor 8`** once these are in, and `docs/command-line.md` updated. ## What the companion does with it Already built, shown only once a Revue's answer carries the fields: - A reactions row under each comment (the counts, yours highlighted, a picker to add one). - @-completion from `mentionable` (today it falls back to the people in the review's conversations). On Bitbucket and Forgejo, where reactions differ or don't exist, leaving `reactions` out is fine: the companion then shows none.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thatrichan/revue#79
No description provided.