Editors: reactions on review comments, and who can be @-mentioned, in --review #79
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The JetBrains companion's review cards (jetbrains 1.2.0) can show emoji reactions on comments and complete @-mentions, as Revue's own conversation does, but the command line doesn't say either yet, and companions only talk to Revue through it. Follows #78 (viewed marks,
editor 7).What the companion needs
--review:"reactions": [{"content": "+1"|"-1"|"laugh"|"hooray"|"confused"|"heart"|"rocket"|"eyes", "count": N, "mine": true|false}],[]when there are none (missing means Revue can't tell, e.g. a service without reactions).revue --react <url> --comment <id> --reaction <content> [--off]: adds your reaction (or, with--off, takes it back) as Revue's own conversation does, answering{"reacted": true|false}; exit codes and--headlessas the other review questions."mentionable": [{"login": "…", "name": "…", "avatar": "https://…"}]at the top of--review's answer: the pull request's people first (author, reviewers, commenters, assignees), then the others who can review in the repository, as Revue's own @ list orders them.editor 8once these are in, anddocs/command-line.mdupdated.What the companion does with it
Already built, shown only once a Revue's answer carries the fields:
mentionable(today it falls back to the people in the review's conversations).On Bitbucket and Forgejo, where reactions differ or don't exist, leaving
reactionsout is fine: the companion then shows none.